Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for custom entity names when registering entities with the worker, resolving issue #79. Previously, entity names were automatically derived from the function or class name, but this change allows developers to specify a custom name explicitly.
Changes:
- Added optional
nameparameter toadd_entitymethods in both_RegistryandTaskHubGrpcWorkerclasses - Implemented
get_entity_namehelper function that supports custom naming via__durable_entity_name__attribute or explicit parameter - Updated e2e tests to validate custom entity naming for both function-based and class-based entities
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| durabletask/task.py | Added get_entity_name function to support custom entity naming with fallback to default behavior |
| durabletask/worker.py | Modified add_entity methods to accept optional name parameter for custom entity names |
| tests/durabletask-azuremanaged/test_dts_function_based_entities_e2e.py | Updated test names and added validation for custom entity names with function-based entities |
| tests/durabletask-azuremanaged/test_dts_class_based_entities_e2e.py | Updated test names and added validation for custom entity names with class-based entities |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
berndverst
approved these changes
Jan 12, 2026
berndverst
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #79